Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate dev environment to nodejs22 #3327

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Nov 18, 2024

Summary

Changes

Please provide a summary of what's being changed

This PR adds support for Node.js 22 and switches the development environment to the same version.

Todos:

  • Manually update aws-cdk and aws-cdk-lib in the workspace
  • Update default runtime for e2e tests here
  • Add new runtime key/val here
  • Remove the patch added here
  • Run the e2e tests again

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3246


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi added the do-not-merge This item should not be merged label Nov 18, 2024
@dreamorosi dreamorosi self-assigned this Nov 18, 2024
@boring-cyborg boring-cyborg bot added automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Nov 18, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Nov 18, 2024
@dreamorosi dreamorosi linked an issue Nov 18, 2024 that may be closed by this pull request
9 tasks
@boring-cyborg boring-cyborg bot added the layers Items related to the Lambda Layers pipeline label Nov 20, 2024
@pull-request-size pull-request-size bot added size/L PRs between 100-499 LOC and removed size/M PR between 30-99 LOC labels Nov 20, 2024
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Nov 20, 2024
Copy link

sonarcloud bot commented Nov 20, 2024

@dreamorosi dreamorosi removed the do-not-merge This item should not be merged label Nov 20, 2024
@dreamorosi dreamorosi marked this pull request as ready for review November 20, 2024 17:45
@dreamorosi dreamorosi requested review from a team as code owners November 20, 2024 17:45
@dreamorosi
Copy link
Contributor Author

@leandrodamascena
Copy link
Contributor

Amazing work @dreamorosi! Approved!

@dreamorosi dreamorosi merged commit 6733584 into main Nov 20, 2024
41 of 42 checks passed
@dreamorosi dreamorosi deleted the chore/nodejs22_switch branch November 20, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Support for Node.js 22 AWS Lambda managed runtime
2 participants