-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): Add appsync resolver event Zod schemas #3301
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
9527023
to
bc745e4
Compare
bc745e4
to
b01ead8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for opening this PR @svozza!
I have done a first quick review and it's looking good, only left a couple minor comments.
On Monday I will do a more comprehensive review with a test build of the utility and get back to you.
2f9c332
to
78faf37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not looking at the TS part because you guys are more expert than me in that area, but looking at the events it looks pretty good to me. I just made an observation because AppSync sends domainName
when invoking with a custom domain name and when not invoking it is None.
Nice work and attention to detail @svozza! 👏
36abe5c
to
d9cabcc
Compare
d9cabcc
to
23fd85c
Compare
23fd85c
to
3db41a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @svozza - appreciate it!
Quality Gate passedIssues Measures |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing. |
Summary
This PR adds Zod schemas for AppSync lambda resolvers and AppSync lambda batch resolvers.
Changes
Issue number:
Resolves #3283.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.