-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): add aws region to kinesis event #3260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I have left a comment on the introduction of .strict()
as I have some concerns on it - but I'm more than open to discuss.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, and for addressing the comments during the review.
Summary
This PR adds missing
awsRegion
in theKinesisDataStreamRecord
schema. I have checked the python version and it is there, so we somehow missed it during implementation. To avoid these cases in the future, I have added a small helper function and tests to make our schemas strict for the test run. This will allow us to find cases where the test event contains properties that we did not include in the schema.Changes
Issue number: closes #3227 closes #3261
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.