Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv(logger): export LoggerInterface #2832

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

sandrokeil
Copy link
Contributor

@sandrokeil sandrokeil commented Jul 24, 2024

Summary

Changes

exports the LoggerInterface

Allows to extend the logger functionality by using the decorator design pattern.

Issue number: #2828

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sandrokeil sandrokeil requested review from a team as code owners July 24, 2024 18:34
@boring-cyborg boring-cyborg bot added the logger This item relates to the Logger Utility label Jul 24, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jul 24, 2024
Copy link

boring-cyborg bot commented Jul 24, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

Copy link

@github-actions github-actions bot added the bug Something isn't working label Jul 24, 2024

This comment was marked as outdated.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jul 24, 2024
@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jul 24, 2024
@dreamorosi dreamorosi changed the title fix(logger): export LoggerInterface improv(logger): export LoggerInterface Jul 24, 2024
@dreamorosi dreamorosi added feature PRs that introduce new features or minor changes and removed bug Something isn't working labels Jul 24, 2024
@github-actions github-actions bot added the enhancement PRs that introduce minor changes, usually to existing features label Jul 24, 2024
@dreamorosi dreamorosi removed the feature PRs that introduce new features or minor changes label Jul 24, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR, and for the interesting discussion in the linked issue!

@dreamorosi dreamorosi merged commit df71d78 into aws-powertools:main Jul 25, 2024
24 checks passed
Copy link

boring-cyborg bot commented Jul 25, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that introduce minor changes, usually to existing features logger This item relates to the Logger Utility size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: export LoggerInterface in @aws-lambda-powertools/logger/types
2 participants