Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maintenance): make jmespath utility public #2289

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR changes the visibility configuration of the new JMESPath utility to public so that it can be published to npm during the next release.

The PR also removes the warning banner that stated that the utility was not available from the utility docs.

Related issues, RFCs

Issue number: #1645

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Mar 27, 2024
@dreamorosi dreamorosi requested review from a team as code owners March 27, 2024 15:01
@dreamorosi dreamorosi linked an issue Mar 27, 2024 that may be closed by this pull request
2 tasks
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation dependencies Changes that touch dependencies, e.g. Dependabot, etc. labels Mar 27, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Mar 27, 2024
@dreamorosi dreamorosi requested a review from sthulb March 27, 2024 15:59
@dreamorosi dreamorosi requested review from am29d and removed request for sthulb April 2, 2024 11:04
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit 671a34d into main Apr 2, 2024
10 checks passed
@dreamorosi dreamorosi deleted the 1645-maintenance-jmespath-utility branch April 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: jmespath utility
2 participants