-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): replace deprecated lib to alternative #2247
chore(deps): replace deprecated lib to alternative #2247
Conversation
Hi, thank you for taking the time to open this PR. As I mentioned in the linked issue, we would like to go in a different direction and instead adopt the If you'd like to continue working on this and see the PR merged I'd kindly ask you to make changes in that regard and remove the Apologies if this might cause you some rework, to avoid this type of occurrence in the future I'd advise to wait for a feedback from a maintainer in the issue before opening the PR, that way we'll be aligned from the beginning and we have a better chance to merge the PR with minor adjustments or as is. |
Hi @yamatatsu, are you still interested in continuing this PR? If not there's no problem at all and we'll take on the task at some point in the near future. Please let me know, or we'll close the PR in a week. |
@dreamorosi |
Hi @yamatatsu, no problem and thanks for coming back to this. I agree with you, we can depend on it as a Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left one comment to fix the implementation and make the tests passing, once that's addressed we can merge this!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this PR and following through with all the feedback!
Congrats 🎉
Description of your changes
This PR remove deprecated library
@aws-sdk/util-base64-node
replacing to@smithy/util-base64
that is official alternative library.See, https://www.npmjs.com/package/@aws-sdk/util-base64-node.
Related issues, RFCs
Issue number: #2246
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.