-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improv(commons): expand type utils functions #2189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice packaged PR, just a minor question on the NaN
edge case.
Co-authored-by: Alexander Schueren <[email protected]>
Had to resolve some merge conflicts since both this & #2190 were touching the same section of the It's now ready for approve & merge. Thanks a lot for the review on both! |
Quality Gate passedIssues Measures |
Description of your changes
This PR adds a series of helper functions to the commons utility to get the type of a value at runtime and perform strict equality.
The helper functions existing before this PR are used across many of the Powertools utilities while the ones added in the PR are mainly for the upcoming JMESPath utility. Overtime we can adopt some of the newer ones wherever necessary on the existing codebase.
Related issues, RFCs
Issue number: #2191
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.