Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layers): add arm64 to integration test matrix #1720

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR adds the AWS Lambda arm64 architecture to the test matrix for our integration tests.

With this addition the tests are now run on both architectures and for all the supported runtimes.

Since we don't use any architecture-specific package, nor any binary or native module, at least for the time being we can afford bundling the utilities once and using the same bundle on both x86_64 and arm64.

The goal of these tests is to continuously verify that the utilities are compatible on both architectures on Lambda.

The PR also shortens the prefixes of all tests by removing the E2E string from the name, changing them from Logger-E2E to just Logger. This is done to account for the addition of the architecture in the name. The full name for the Stack and resources deployed as part of the test will be Logger-18-arm-12345-featureName.

Important

While the PR will be merged on main shortly, we want to take a few weeks of time to run tests and thoroughly ensure that we don't need to build the utilities on arm. For this reason we plan on marking the layers as arm64-ready only as part of our upcoming v2 release (#1714).

Related issues, RFCs

Issue number: #1374

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team as a code owner September 27, 2023 19:40
@dreamorosi dreamorosi self-assigned this Sep 27, 2023
@dreamorosi dreamorosi linked an issue Sep 27, 2023 that may be closed by this pull request
2 tasks
@boring-cyborg boring-cyborg bot added automation This item relates to automation tests PRs that add or change tests labels Sep 27, 2023
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Sep 27, 2023
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Sep 27, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dreamorosi
Copy link
Contributor Author

Successful integration test with both architectures: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/6331812964

@am29d am29d merged commit 61ad5ac into main Sep 28, 2023
47 checks passed
@am29d am29d deleted the 1374-feature-request-arm64-support-for-lambda-layers branch September 28, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation feature PRs that introduce new features or minor changes size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: arm64 support for Lambda Layers
2 participants