feat(layers): add arm64
to integration test matrix
#1720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds the AWS Lambda
arm64
architecture to the test matrix for our integration tests.With this addition the tests are now run on both architectures and for all the supported runtimes.
Since we don't use any architecture-specific package, nor any binary or native module, at least for the time being we can afford bundling the utilities once and using the same bundle on both
x86_64
andarm64
.The goal of these tests is to continuously verify that the utilities are compatible on both architectures on Lambda.
The PR also shortens the prefixes of all tests by removing the
E2E
string from the name, changing them fromLogger-E2E
to justLogger
. This is done to account for the addition of the architecture in the name. The full name for the Stack and resources deployed as part of the test will beLogger-18-arm-12345-featureName
.Important
While the PR will be merged on
main
shortly, we want to take a few weeks of time to run tests and thoroughly ensure that we don't need to build the utilities on arm. For this reason we plan on marking the layers asarm64
-ready only as part of our upcoming v2 release (#1714).Related issues, RFCs
Issue number: #1374
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.