Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batch): Update processor to pass only context to handler #1637

Merged
merged 2 commits into from
Jul 29, 2023
Merged

fix(batch): Update processor to pass only context to handler #1637

merged 2 commits into from
Jul 29, 2023

Conversation

erikayao93
Copy link
Contributor

Description of your changes

  • Updated process for both sync and async invocation
  • Updated test context handlers to receive only Context

Related issues, RFCs

Issue number: #1635

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@erikayao93 erikayao93 requested a review from a team as a code owner July 28, 2023 21:44
@boring-cyborg boring-cyborg bot added batch This item relates to the Batch Processing Utility tests PRs that add or change tests labels Jul 28, 2023
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Jul 28, 2023
@github-actions github-actions bot added the bug Something isn't working label Jul 29, 2023
dreamorosi
dreamorosi reviewed Jul 29, 2023
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR!

packages/batch/tests/helpers/handlers.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dreamorosi dreamorosi self-requested a review July 29, 2023 12:08
@dreamorosi dreamorosi linked an issue Jul 29, 2023 that may be closed by this pull request
Bug: Lambda context access in batch processing record handler #1635
Closed
dreamorosi
dreamorosi approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for offering to contribute a fix for this!

@dreamorosi dreamorosi merged commit 6fa09b2 into aws-powertools:main Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@erikayao93 erikayao93

Labels
batch This item relates to the Batch Processing Utility bug Something isn't working size/S PR between 10-29 LOC tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Lambda context access in batch processing record handler
2 participants
@erikayao93 @dreamorosi