-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idempotency): makeHandlerIdempotent
middy middleware
#1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
boring-cyborg
bot
added
idempotency
This item relates to the Idempotency Utility
tests
PRs that add or change tests
labels
May 24, 2023
github-actions
bot
added
the
feature
PRs that introduce new features or minor changes
label
May 24, 2023
dreamorosi
commented
May 24, 2023
dreamorosi
commented
May 24, 2023
dreamorosi
commented
May 24, 2023
pull-request-size
bot
added
size/XL
PRs between 500-999 LOC, often PRs that grown with feedback
and removed
size/L
PRs between 100-499 LOC
labels
Jun 1, 2023
am29d
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
PRs that introduce new features or minor changes
idempotency
This item relates to the Idempotency Utility
size/XL
PRs between 500-999 LOC, often PRs that grown with feedback
tests
PRs that add or change tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces a new Middy middleware that allows to wrap a Lambda handler and make it idempotent.
The middleware can be used like this:
Implementation details
The first detail to notice is that contrary to the function wrapper and the class method decorator, this middleware doesn't leverage fully the
IdempotencyHandler
class. The reason for this is that Middy has a specific lifecycle when it comes to logic running before, after, and in case of error thrown by the handler. The current implementation of theIdempotencyHandler
groups certain actions together and expects certain signatures and a class instantiation and as such it's not possible for the middleware to use the same method all the time.As a result, the middleware interacts with the persistence store directly and is in charge of handling/throwing the errors. This allows the middleware to follow its own patterns, however moving forward we will need to make sure we keep the two implementations in sync.
Related issues, RFCs
Issue number: #1293
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.