Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update lerna to latest version #1394

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As detailed in the linked issue, the version of lerna used prior to this PR was over a year old. As such it wasn't receiving any updates and this was causing some development only vulnerabilities to appear in the npm audit.

This PR updates the package to the latest version and removes some redundant npm scripts and command flags.

I have tested this setup locally by versioning & publishing to a verdaccio registry. I have a good amount of confidence but we'll have to test this definitively during the next release.

Once merged this PR closes #1393

Related issues, RFCs

Issue number: #1393

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi linked an issue Apr 1, 2023 that may be closed by this pull request
2 tasks
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Apr 1, 2023
@dreamorosi dreamorosi self-assigned this Apr 1, 2023
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Apr 1, 2023
@dreamorosi dreamorosi merged commit 7a9d499 into main Apr 1, 2023
@dreamorosi dreamorosi deleted the 1393-maintenance-update-lerna-to-latest branch April 1, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: update Lerna to latest
1 participant