Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): convert deprecated set-output command #1391

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

In preparation of the set-output deprecation from GitHub, this PR removes all its remaining usages from the workflows in this repo.

The PR applies similar changes to the ones already merged weeks ago in the Python repo aws-powertools/powertools-lambda-python#1957, as well as updating the commit sha for one of the custom actions that was using the deprecated action and that was updated in the meanwhile.

Once merged this PR fixes #1127.

Related issues, RFCs

Issue number: #1127

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Mar 31, 2023
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Mar 31, 2023
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Mar 31, 2023
@dreamorosi dreamorosi merged commit 0136e59 into main Mar 31, 2023
@dreamorosi dreamorosi deleted the 1127-convert-deprecated-set-output-command branch March 31, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Convert deprecated set-output command on Github Actions workflows
2 participants