-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(logger): update child logger docs section and snippets #1286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Minor suggestions/rewording on a couple of sentences.
Co-authored-by: Andrea Amorosi <[email protected]>
Co-authored-by: Andrea Amorosi <[email protected]>
I like this sentence! Thanks for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for the help on this 🎉
Description of your changes
This PR is intended to improve docs for child loggers (
createChild
method). It is the last part of improving the child logger implementation, unit tests, and documentation. In the first PR #1178 child Logger implementation was changed, and new tests were introduced, in this PR #1264 implementation was improved, and new tests were introduced that cover all attributes inherited from a parent logger.How to verify this change
Related issues, RFCs
Issue number: #483
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.