-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): metadata and dimensions not cleared on publish #1129
fix(metrics): metadata and dimensions not cleared on publish #1129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
The changes seem appropriate to me and the automated checks are green.
I have requested a second review by one of the other maintainers before merging.
Thank you, Andrea @dreamorosi. If you need help with other issues, feel free to mention me. |
Doubt on Unit test . neeed a sec to review
Hello @flochaz, what is your doubt? Should I add more or fix existing tests? |
Sorry got dragged on something else. Double checked and all good. approving. thx a lot for the work |
Hi @shdq, the PR is merged and the change will be available in the next release. Congrats for getting your first PR merged in this project 🎉 To answer your question, I would start with issues that have the |
Description of your changes
To fix this bug,
clearDimensions();
andclearMetadata();
are added topublishStoredMetrics()
method to clear metadata and dimensions.Bug described and reproduced in #1115.
How to verify this change
Related issues, RFCs
Issue number: #1115
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.