Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): fix ts-node version for layer-publisher #1112

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Oct 10, 2022

Layer publisher build is failing due to mismatch between NodeJS runtime version and ts-node version (see https://github.com/awslabs/aws-lambda-powertools-typescript/actions/runs/3217811362/jobs/5261224013 for more details).

Description of your changes

bump ts-node to 10.x.x version.

How to verify this change

cd layer-publisher
npm ci
npm run cdk synth

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Oct 10, 2022
@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Oct 10, 2022
@flochaz flochaz merged commit ee243de into main Oct 10, 2022
@flochaz flochaz deleted the fix/layerGithubAction branch October 10, 2022 18:12
@github-actions
Copy link
Contributor

@awslabs/aws-lambda-powertools-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants