Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracer): allow disabling result capture for decorators and middleware #1065
feat(tracer): allow disabling result capture for decorators and middleware #1065
Changes from all commits
cc59160
6eedbbe
14ccc2f
ae72d52
81fd698
e456670
dd42e52
cb4de92
2c84e5f
9597970
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we convert all the instances of this
if/else
to this notation? This is mostly for readability & consistency with the rest of the codebase (example)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make readability improvements here. But, before we do that, I'd like to point out that before this PR,
@tracer.captureMethod()
was capturing results by default unless the environment variable was set. For the newly proposed logic as provided, I believe these two cases would not capture responses by default:@tracer.captureMethod()
->options
will be undefined and the first conjunct of the conditional will be false.@tracer.captureMethod({ captureResponse: undefined })
->options?.captureResponse
will not equal true, therefore the second conjunct of the conditional will be false.I believe backward compatible logic here would be either
!options || options.captureResponse !== false
or!(options && options.captureResponse === false)
, but at least to me, either requires some mental gymnastics to read.For comparison's sake: To make the code more readable, in these cases in the CDK project, we often do two things:
We put our defaults higher up in a block of code, assigning them earlier, more conspicuously as default values, where the function of nullish coalescing (
??
) is more obvious. Like this: https://github.com/aws/aws-cdk/blob/1e305e6eed6b4ede78df10cbaadb8b578c1e6baa/packages/%40aws-cdk/aws-lambda-nodejs/lib/function.ts#L94-L96We also typically provide an empty object for optional arguments so we can avoid the optional chaining (
?.
) operator. https://github.com/aws/aws-cdk/blob/1e305e6eed6b4ede78df10cbaadb8b578c1e6baa/packages/%40aws-cdk/aws-lambda-nodejs/lib/function.ts#L87If we took these approaches, perhaps the code could look like this:
Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation, I now understand your original proposal & I agree with the syntax :)
I'm going to leave this open so that others can benefit from this explanation.