Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger|metrics): return decorated class #489

Merged
merged 3 commits into from
Jan 24, 2022
Merged

fix(logger|metrics): return decorated class #489

merged 3 commits into from
Jan 24, 2022

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Jan 19, 2022 •
edited
Loading

Description of your changes

As evidenced in #399 Logger and Metrics were not correctly returning the decorated class when used as decorators. This PR aims at correcting that behaviour and add unit tests to check that to avoid future regressions.

Additionally this PR removes two unused & leftover files in the Logger package.

How to verify this change

Checkout the branch & run tests or check the GitHub checks results.

Related issues, RFCs

#399

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 19, 2022
@dreamorosi dreamorosi self-assigned this Jan 19, 2022
@dreamorosi dreamorosi added fix logger This item relates to the Logger Utility metrics This item relates to the Metrics Utility labels Jan 19, 2022
@dreamorosi dreamorosi requested review from flochaz and ijemmy January 19, 2022 14:47
flochaz
flochaz approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@flochaz flochaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@dreamorosi
Copy link
Contributor Author

dreamorosi commented Jan 21, 2022 •
edited
Loading

Will merge once #498 is merged.

@dreamorosi dreamorosi merged commit 014c5bd into main Jan 24, 2022
@dreamorosi dreamorosi deleted the fix/return_decorated_class branch January 24, 2022 15:07
saragerion added a commit that referenced this pull request Jan 25, 2022
@saragerion @flochaz
@dependabot @dreamorosi
build(all): add concurrency to github workflows (#499)
900aba9 
* build(all): add concurrency to github actions

* fix(build): revert group name for release

* chore(examples): fix version bumping of examples (#498)

* force fix version of deps for examples

* add package.json to bump commit

* build(deps): bump aws-sdk from 2.1056.0 to 2.1062.0 (#506)

Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1056.0 to 2.1062.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1056.0...v2.1062.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump @aws-sdk/client-sts from 3.46.0 to 3.48.0 (#505)

Bumps [@aws-sdk/client-sts](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-sts) from 3.46.0 to 3.48.0.
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-sts/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.48.0/clients/client-sts)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-sts"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump typescript from 4.5.4 to 4.5.5 (#507)

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.5.4 to 4.5.5.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.5.4...v4.5.5)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump @types/node from 17.0.8 to 17.0.10 (#488)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.8 to 17.0.10.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(logger|metrics): properly return decorated class (#489)

* fix: logger to return decorated class

* fix: metrics to return decorated class

* chore: remove leftover files from logger

* feat: Add codespaces/gitpod support (#485)

* feat: initial codespaces support

* chore: example commit to disable a plugin

* fix: rather use lerna-ci

* fix: forgot to remove "cd "to examples

* feat: Add gitpod support

* chore: move to node 14 for both gitpod and codespaces

* fix: gitpod specific way

* chore: use nvmrc to ease shared config

* docs: comment out docs for gitpod

* fix: force npm to be 8

* feat: finalize extensions

* chore: remove ones that don't work

* fix: container typo

* build(all): add concurrency to github actions

* fix(build): revert group name for release

Co-authored-by: Florian Chazal <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrea Amorosi <[email protected]>
Co-authored-by: Michael Brewer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragerion saragerion saragerion approved these changes

@flochaz flochaz flochaz approved these changes

@ijemmy ijemmy Awaiting requested review from ijemmy

Assignees

@dreamorosi dreamorosi

Labels
logger This item relates to the Logger Utility metrics This item relates to the Metrics Utility
Projects
None yet
Milestone
production-ready-release
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamorosi @flochaz @saragerion