Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): correctly export LogFormatter #479

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Jan 17, 2022

Description of your changes

This PR aims at resolving the issue highlighted in #393 that prevented customers to use LogFormatter (from Logger) as described in the docs.

How to verify this change

Build the utility with npm pack & install it in other project/examples, then try to use to see exported class.

See below:
Screenshot 2022-01-17 at 14 47 18

Related issues, RFCs

#393

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Jan 17, 2022
@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2022
@dreamorosi dreamorosi added the logger This item relates to the Logger Utility label Jan 17, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 17, 2022
@dreamorosi dreamorosi marked this pull request as ready for review January 17, 2022 13:51
@dreamorosi dreamorosi merged commit 7f91566 into main Jan 17, 2022
@dreamorosi dreamorosi deleted the fix/logger/export_log_formatter branch January 17, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logger This item relates to the Logger Utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: LogFormatter isn't exported from Logger module so users cannot use custom formatter feature
3 participants