Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(batch): snippet typo in custom batch processor #961

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

thehananbhat
Copy link
Contributor

@thehananbhat thehananbhat commented Jan 17, 2022

Description of changes:

Variable ddb_table is not defined in the class. Updated with instance variable self.ddb_table
Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/utilities/batch.md

Under "Creating a custom batch processor" example the ddb_table in not defined. Instead consider `self.ddb_table`
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 17, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 17, 2022

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so so much for this fix @thehananbhat

@heitorlessa heitorlessa changed the title docs: Minor fix in the example given under "Creating a custom batch processor" docs(batch): snippet typo in custom batch processor Jan 17, 2022
@heitorlessa heitorlessa merged commit e758bf6 into aws-powertools:develop Jan 17, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 17, 2022

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

heitorlessa added a commit that referenced this pull request Jan 20, 2022
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  fix(batch): report multiple failures (#967)
  docs(tutorial): fix path to images (#963)
  Update documentation mistake (#961)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants