Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(batch): snippet typo on batch processed messages iteration #951

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

j2clerck
Copy link
Contributor

@j2clerck j2clerck commented Jan 11, 2022

Issue #, if available:

Description of changes:

This is a small change to the documentation, fixing an extra iteration over processed_messages in batch processor.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/utilities/batch.md

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2022
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #951 (0d2498e) into develop (a1ee4e9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #951      +/-   ##
===========================================
- Coverage    99.96%   99.96%   -0.01%     
===========================================
  Files          119      119              
  Lines         5322     5320       -2     
  Branches       614      613       -1     
===========================================
- Hits          5320     5318       -2     
  Partials         2        2              
Impacted Files Coverage Δ
...ities/data_classes/api_gateway_authorizer_event.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ee4e9...0d2498e. Read the comment docs.

@heitorlessa heitorlessa changed the title docs: fix typo in sample iteration over batch processed messages. docs(batch): typo in sample iteration over batch processed messages Jan 17, 2022
@heitorlessa
Copy link
Contributor

Thanks a lot again @j2clerck ;)

@heitorlessa heitorlessa changed the title docs(batch): typo in sample iteration over batch processed messages docs(batch): snippet typo on batch processed messages iteration Jan 17, 2022
@heitorlessa heitorlessa merged commit 7414f89 into aws-powertools:develop Jan 17, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 17, 2022

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants