Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigateway): support @app.not_found() syntax & housekeeping #926

Merged
merged 7 commits into from
Dec 30, 2021
Merged

fix(apigateway): support @app.not_found() syntax & housekeeping #926

merged 7 commits into from
Dec 30, 2021

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Dec 23, 2021 •
edited
Loading

Issue #, if available:

Description of changes:

Changes:

  • Allow for @app.not_found() decorator
  • Add docstrings and typing to strtobool
  • Add code coverage for strtobool
  • Minor docstring typos
  • Add test for DynamoDBPersistenceLayer with a sort_key_attr

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@michaelbrewer
fix(event-handler): allow for @app.not_found() decorator
a3adb5f 
Changes:
- allow for `@app.not_found()` decorator
- add typing to `strtobool` and add code coverage
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #926 (f5685d0) into develop (cced6c4) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #926      +/-   ##
===========================================
+ Coverage    99.88%   99.96%   +0.07%     
===========================================
  Files          118      118              
  Lines         5272     5274       +2     
  Branches       605      606       +1     
===========================================
+ Hits          5266     5272       +6     
+ Misses           2        0       -2     
+ Partials         4        2       -2
Impacted Files Coverage Δ
.../utilities/data_classes/cognito_user_pool_event.py 100.00% <ø> (ø)
...lambda_powertools/utilities/data_classes/common.py 100.00% <ø> (ø)
...bda_powertools/utilities/idempotency/exceptions.py 100.00% <ø> (ø)
aws_lambda_powertools/event_handler/api_gateway.py 100.00% <100.00%> (ø)
aws_lambda_powertools/shared/functions.py 100.00% <100.00%> (+16.66%) ⬆️
...da_powertools/utilities/idempotency/idempotency.py 100.00% <100.00%> (ø)
...ools/utilities/idempotency/persistence/dynamodb.py 100.00% <0.00%> (+2.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cced6c4...f5685d0. Read the comment docs.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 25, 2021
@michaelbrewer michaelbrewer changed the title fix(event-handler): allow for @app.not_found() decorator fix(event-handler): allow for @app.not_found() decorator and housekeeping Dec 25, 2021
@heitorlessa heitorlessa added the internal Maintenance changes label Dec 29, 2021
@heitorlessa heitorlessa changed the title fix(event-handler): allow for @app.not_found() decorator and housekeeping fix(apigateway): allow for @app.not_found() decorator and housekeeping Dec 29, 2021
heitorlessa
heitorlessa suggested changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change in reverting strtobool to be a public function

@heitorlessa heitorlessa added the bug Something isn't working label Dec 30, 2021
@heitorlessa
Copy link
Contributor

Thanks a lot Mike for the quick fix & the housekeeping

@heitorlessa heitorlessa changed the title fix(apigateway): allow for @app.not_found() decorator and housekeeping fix(apigateway): support @app.not_found() syntax & housekeeping Dec 30, 2021
@heitorlessa heitorlessa merged commit bdf307b into aws-powertools:develop Dec 30, 2021
@heitorlessa heitorlessa deleted the fix-65 branch December 30, 2021 09:06
heitorlessa added a commit to ran-isenberg/aws-lambda-powertools-python that referenced this pull request Dec 31, 2021
@heitorlessa
Merge branch 'develop' of https://github.com/awslabs/aws-lambda-power…
9a335f0 
…tools-python into complex

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: (24 commits)
  docs: consistency around admonitions and snippets (aws-powertools#919)
  chore(deps-dev): bump mypy from 0.920 to 0.930 (aws-powertools#925)
  fix(event-sources): handle dynamodb null type as none, not bool (aws-powertools#929)
  fix(apigateway): support @app.not_found() syntax & housekeeping (aws-powertools#926)
  docs: Added GraphQL Sample API to Examples section of README.md (aws-powertools#930)
  feat(idempotency): support dataclasses & pydantic models payloads (aws-powertools#908)
  feat(tracer): ignore tracing for certain hostname(s) or url(s) (aws-powertools#910)
  feat(event-sources): cache parsed json in data class (aws-powertools#909)
  fix(warning): future distutils deprecation (aws-powertools#921)
  docs(batch): remove leftover from legacy
  docs(layer): bump Lambda Layer to version 6
  chore: bump to 1.23.0
  docs(apigateway): add new not_found feature (aws-powertools#915)
  docs: external reference to cloudformation custom resource helper (aws-powertools#914)
  feat(logger): allow handler with custom kwargs signature (aws-powertools#913)
  chore: minor housekeeping before release (aws-powertools#912)
  chore(deps-dev): bump mypy from 0.910 to 0.920 (aws-powertools#903)
  feat(batch): new BatchProcessor for SQS, DynamoDB, Kinesis (aws-powertools#886)
  fix(parser): overload parse when using envelope (aws-powertools#885)
  fix(parser): kinesis sequence number is str, not int (aws-powertools#907)
  ...
heitorlessa added a commit to huonw/aws-lambda-powertools-python that referenced this pull request Dec 31, 2021
@heitorlessa
Merge branch 'develop' of https://github.com/awslabs/aws-lambda-power…
0ab103c 
…tools-python into feature/905-datetime

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  feat(feature_flags): support beyond boolean values (JSON values) (aws-powertools#804)
  docs: consistency around admonitions and snippets (aws-powertools#919)
  chore(deps-dev): bump mypy from 0.920 to 0.930 (aws-powertools#925)
  fix(event-sources): handle dynamodb null type as none, not bool (aws-powertools#929)
  fix(apigateway): support @app.not_found() syntax & housekeeping (aws-powertools#926)
  docs: Added GraphQL Sample API to Examples section of README.md (aws-powertools#930)
  feat(idempotency): support dataclasses & pydantic models payloads (aws-powertools#908)
  feat(tracer): ignore tracing for certain hostname(s) or url(s) (aws-powertools#910)
  feat(event-sources): cache parsed json in data class (aws-powertools#909)
  fix(warning): future distutils deprecation (aws-powertools#921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitorlessa heitorlessa heitorlessa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbrewer @codecov-commenter @heitorlessa