docs(middleware): fix sample code #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
documentation
pull-request-size
bot
added
the
size/XS
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
Thanks a lot @arthurf1969 !! |
heitorlessa
approved these changes
Oct 23, 2021
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
michaelbrewer
pushed a commit
to gyft/aws-lambda-powertools-python
that referenced
this pull request
Oct 24, 2021
heitorlessa
added a commit
to gyft/aws-lambda-powertools-python
that referenced
this pull request
Oct 29, 2021
…uter * michaelbrewer/docs/router: feat(data-classes): ActiveMQ and RabbitMQ support (aws-powertools#770) feat(appsync): add Router to allow large resolver composition (aws-powertools#776) chore(deps-dev): bump mkdocs-material from 7.3.3 to 7.3.5 (aws-powertools#781) chore(deps-dev): bump flake8-isort from 4.0.0 to 4.1.1 (aws-powertools#785) chore(deps): bump urllib3 from 1.26.4 to 1.26.5 (aws-powertools#787) chore(deps-dev): bump flake8-eradicate from 1.1.0 to 1.2.0 (aws-powertools#784) chore(deps): bump boto3 from 1.18.61 to 1.19.6 (aws-powertools#783) chore(deps-dev): bump pytest-asyncio from 0.15.1 to 0.16.0 (aws-powertools#782) docs: fix indentation of SAM snippets in install section (aws-powertools#778) Fix middleware sample (aws-powertools#772) Removed unused import, added typing imports, fixed typo in example. (aws-powertools#774) Fix middleware sample (aws-powertools#772) Removed unused import, added typing imports, fixed typo in example. (aws-powertools#774) Update docs/core/event_handler/api_gateway.md # Conflicts: # docs/core/event_handler/api_gateway.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The sample provided in the documentation for the middleware is not working as expected. The value of the field variable is overwritten that later on causes failures. With this change we provide a sample that can be used as a starting point.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/utilities/middleware_factory.md