-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idempotency): add support for custom Idempotency key prefix #5898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5898 +/- ##
===========================================
- Coverage 96.20% 96.20% -0.01%
===========================================
Files 232 232
Lines 10956 10955 -1
Branches 2027 2026 -1
===========================================
- Hits 10540 10539 -1
Misses 327 327
Partials 89 89 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick turnaround, looks good.
Will open an issue in TypeScript as well!
Issue number: #5897
Summary
Changes
This PR introduces an optional
idempotency_key_custom_prefix
parameter to the@idempotent_function
and@idempotent
decorators, allowing customers more flexibility in managing idempotency key generation.Key points for this decision
Currently, idempotency keys are automatically generated based on the function's name and arguments. This can create challenges during:
User experience
Decorating standalone functions
Decorating the Lambda handler
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.