-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_handler): mutualTLS Security Scheme for OpenAPI #5484
feat(event_handler): mutualTLS Security Scheme for OpenAPI #5484
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5484 +/- ##
========================================
Coverage 96.15% 96.16%
========================================
Files 229 229
Lines 10807 10810 +3
Branches 2007 2007
========================================
+ Hits 10392 10395 +3
Misses 327 327
Partials 88 88 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Thanks a lot @Sector95! Approved! |
No problem! Looks like it needs another reviewer since you committed to the branch though. |
Yeah! @anafalcao will approve this soon! Just to explain: I just added a new test to increase code coverage and make sure we're not missing anything. To be honest, it was just to control my OCD with tests lol. |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #5483
Summary
Changes
The OpenAPI 3.1 spec supports
mutualTLS
as an additional security scheme, this PR adds the relevant models and documentation to enable support of that scheme in the framework.User experience
Currently there is no easy way to specify an mTLS security scheme using the framework. This change would enable a user to specify it in the same as other schemes, like
OAuth2
andHTTPBearer
types.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.