-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data-classes): include milliseconds in scalar types #504
fix(data-classes): include milliseconds in scalar types #504
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #504 +/- ##
========================================
Coverage 99.90% 99.90%
========================================
Files 105 105
Lines 4234 4234
Branches 206 206
========================================
Hits 4230 4230
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
@heitorlessa I think that |
@heitorlessa seems to work as microseconds, so should i still trim off the extra 3 positions? or leave it |
thanks for the fix!! Let's trim off to stay as milliseconds ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trim last three to stick as ms [:-3]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, Mike!
Note to self: break down test_data_classes
as it's 1.3K LOC atm
It would be great if pytest can run parts in parallel :). Then i would definitely help split up things. |
Issue #, if available:
#503
Description of changes:
Set the formatted output to include milliseconds
fixes #503
Checklist
Breaking change checklist
Potentially a breaking change if expecting only seconds.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.