Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!(jmespath_utils): deprecate extract_data_from_envelope in jmespath_utils and replace with query #4906

Closed
wants to merge 0 commits into from

Conversation

n-k1
Copy link
Contributor

@n-k1 n-k1 commented Aug 7, 2024

Issue number: #4218

Summary

Changes

  • Added a query method in jmespath_utils/__init__.py with the same implementation as extract_data_from_envelope
  • Added a warning to extract_data_from_envelope and updated docstring

User experience

extract_data_from_envelope will continue to work with a deprecation warning and will be removed in the next major version. query will replace extract_data_from_envelope.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

This is not a breaking change. extract_data_from_envelope will continue to work with a deprecation warning and will only be removed in the next major version.

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@n-k1 n-k1 requested a review from a team as a code owner August 7, 2024 13:18
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation jmespath JMESPath Functions utility logger tests labels Aug 7, 2024
Copy link

boring-cyborg bot commented Aug 7, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2024
@n-k1 n-k1 closed this Aug 7, 2024
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation jmespath JMESPath Functions utility logger size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant