-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): Adds DDB deserialization to DynamoDBStreamChangedRecordModel #4401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sthulb! This PR will introduce a great developer experience in Powertools V3, that's super cool!!
Before I review, can you pls add some tests?
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @sthulb! Approved.
Issue number: #4219
Summary
Changes
This change adds deserialisation to DynamoDBStreamChangedRecordModel, allowing for rapid access to:
Keys
OldImage
NewImage
It also adds properties for existing fields.
User experience
Before
After
This change also relocates the DDB deserialiser work introduced in #1619 to it's own file located in
aws_lambda_powertools.shared.dynamodb_deseraiizer
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
This is a breaking change.
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.