fix(idempotency): POWERTOOLS_IDEMPOTENCY_DISABLED should respect truthy values

[stevenhoelscher]

Issue number: 4390

Summary

Changes

• When evaluating the POWERTOOLS_IDEMPOTENCY_DISABLED environment variable, first transform the string truthy value into a bool.

User experience

• Before: A user sets POWERTOOLS_IDEMPOTENCY_DISABLED=false but the idempotency layer would actually be disabled
• After: A user sets POWERTOOLS_IDEMPOTENCY_DISABLED=false and the idempotency layer would not be disabled

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[boring-cyborg]

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

[heitorlessa]

Looking into it shortly (in transit)

…

On Thu, 23 May 2024 at 07:34, sonarcloud[bot] ***@***.***> wrote: [image: Quality Gate Passed] <https://sonarcloud.io/dashboard?id=aws-powertools_powertools-lambda-python&pullRequest=4391> *Quality Gate passed* Issues <https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0 New issues <https://sonarcloud.io/project/issues?id=aws-powertools_powertools-lambda-python&pullRequest=4391&resolved=false&sinceLeakPeriod=true> <https://camo.githubusercontent.com/6e7f22e3d7f9764d9cfb28e3b8ee5ebb5f711c5bb2dcec8a6db6b0d958d63134/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67> 0 Accepted issues <https://sonarcloud.io/project/issues?id=aws-powertools_powertools-lambda-python&pullRequest=4391&resolutions=WONTFIX> Measures <https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0 Security Hotspots <https://sonarcloud.io/project/security_hotspots?id=aws-powertools_powertools-lambda-python&pullRequest=4391&resolved=false&sinceLeakPeriod=true> <https://camo.githubusercontent.com/6e8b454bb65140d4b85e92f6515ea1f7f1d4676313480a31efe2083f12730585/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f6e6f2d646174612d313670782e706e67> No data about Coverage <https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67> 0.0% Duplication on New Code <https://sonarcloud.io/component_measures?id=aws-powertools_powertools-lambda-python&pullRequest=4391&metric=new_duplicated_lines_density&view=list> See analysis details on SonarCloud <https://sonarcloud.io/dashboard?id=aws-powertools_powertools-lambda-python&pullRequest=4391> — Reply to this email directly, view it on GitHub <#4391 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZPQBAFQQWXLYZXEB5DM6LZDTXLJAVCNFSM6AAAAABIEIVOCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGYYDKNJSGQ> . You are receiving this because your review was requested.Message ID: ***@***.***>

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (e14e768) to head (ffe8e00).
Report is 519 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4391      +/-   ##
===========================================
- Coverage    96.38%   96.28%   -0.10%     
===========================================
  Files          214      219       +5     
  Lines        10030    10489     +459     
  Branches      1846     1871      +25     
===========================================
+ Hits          9667    10099     +432     
- Misses         259      274      +15     
- Partials       104      116      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leandrodamascena]

Hi @stevenhoelscher! Thank you so much for submitting this PR. It's a great catch, and I'm glad you discovered this long-standing bug. We really appreciate you taking the time to fix it!

I made only two changes in this PR:
1 - I set the default value of os.getenv to false, making the behavior more explicit.
2 - I included a test case to ensure the correct behavior.

Thanks

[heitorlessa]

let's add a warning to prevent customers forgetting it's disabled in dev but promoting it to prod.

[leandrodamascena]

@heitorlessa ready to review again.

[heitorlessa]

Last question to clarify a piece I missed (changes are great!!)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[boring-cyborg]

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

[heitorlessa]

hey @stevenhoelscher thank you so much for kicking this off <3