-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nested-event-sources): Generic unwrapping of event source data #4069
base: v2
Are you sure you want to change the base?
Conversation
…tom logic for unwrapping some events
@rafaelgsr @leandrodamascena Please take a look at this PR and let me know if I need to change anything. I will work on fixing the linting soon. I had a couple general questions as well:
|
Discussed the above questions:
Probably ok to do this, but @leandrodamascena will confirm.
Decided we should just decode without needing a flag since customers will always need to decode their data. Still discussing how to decode for different data classes. |
Quality Gate passedIssues Measures |
@leandrodamascena think this is something @sthulb could review and take it to the finish line? |
Hello @heitorlessa! I completely missed that comment. @seshubaws has done a great job so far and we can help finalize this PR and launch this new feature. I'll assing to Simon after we finish some internal things related to V3. |
Issue number:
#2678
Summary
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
#2678
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.