-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger): add method to return currently configured keys #4033
feat(logger): add method to return currently configured keys #4033
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #4033 +/- ##
===========================================
- Coverage 96.38% 96.25% -0.13%
===========================================
Files 214 216 +2
Lines 10030 10393 +363
Branches 1846 1927 +81
===========================================
+ Hits 9667 10004 +337
- Misses 259 275 +16
- Partials 104 114 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Just left two tiny comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for the changes discussed offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work :D
Quality Gate passedIssues Measures |
Issue number: #3505
Summary
Changes
This pull request introduces a new method
current_keys
to the Logger utility. The primary objective of this method is to offer a straightforward approach for retrieving the currently configured keys utilized within the logger. Additionally, it serves to prevent mistakes such as overwriting keys.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.