-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parameter): improve AppConfig cached configuration retrieval #3195
fix(parameter): improve AppConfig cached configuration retrieval #3195
Conversation
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3195 +/- ##
========================================
Coverage 95.96% 95.96%
========================================
Files 195 195
Lines 8387 8387
Branches 1563 1563
========================================
Hits 8049 8049
Misses 276 276
Partials 62 62
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny changes - LGTM!!
-
Update PR body - what's the problem of making multiple calls? This will help improve the PR title in the Changelog too
-
Code comment on why we need to store last returned as a dict
-
Create an issue to add a E2E test after the release (non-blocking) so we can be confident there's no regression in the future
get_latest_configuration
behavior for multiple configuration calls
get_latest_configuration
behavior for multiple configuration calls
Looking at this now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left one tiny thing, but it's ready to go!
Kudos, SonarCloud Quality Gate passed! |
Issue number: #3194
Summary
Changes
This pull request fix an issue related to
AppConfig
caching behavior when multiple configuration calls are made using the same application/environment.The expected behavior of
get_latest_configuration
function is to return aNone/null
value when no new configuration is available. This design is intentional and value should be cached on the customer side. We created a dictionary for storing the most recently retrieved value for a specific configuration profile.For additional context and details regarding the behavior of
get_latest_configuration
, please refer to the official AWS AppConfig documentation.User experience
There is no change in the user experience, but it fixes the error.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.