-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_handler): add support to VPC Lattice payload v2 #3153
feat(event_handler): add support to VPC Lattice payload v2 #3153
Conversation
Hi @stephenbawks! I believe there is some testing and documentation left to be written about this new event source data class. Can you check it please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests before reviewing this.
I see the CI failed because Ruff is complaining. It's easy to fix :D Thanks for updating this event handler, @stephenbawks! You always tune in to new AWS features. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3153 +/- ##
===========================================
+ Coverage 95.88% 95.95% +0.07%
===========================================
Files 193 195 +2
Lines 8241 8364 +123
Branches 1536 1559 +23
===========================================
+ Hits 7902 8026 +124
Misses 276 276
+ Partials 63 62 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to review the event handler with this new payload. Do you want to add tests or do I?
Hey @heitorlessa! Can you review this PR, please? |
Hey @heitorlessa! I updated the PR body and addressed your feedback. Can you review it again, please? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Issue number: #3160
Summary
Changes
As of September 8 there is a new VPC Lattice Event Type for Lambda.
When you create or update a target group of type LAMBDA, you can specify the version of the event structure that your Lambda function receives. The possible versions are
V1
andV2
.https://docs.aws.amazon.com/vpc-lattice/latest/ug/lambda-functions.html
User experience
Using VPCLatticeV2Resolver Event Handler
Using VPCLatticeEventV2 Data Class
Using VPCLatticeEventV2 Parser
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.