-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(event_handler): expanding safe URI characters to include +$& #3026
fix(event_handler): expanding safe URI characters to include +$& #3026
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #3026 +/- ##
========================================
Coverage 96.56% 96.56%
========================================
Files 175 175
Lines 7825 7825
Branches 1476 1476
========================================
Hits 7556 7556
Misses 217 217
Partials 52 52
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nejcskofic! Thanks a lot for fixing this! I just changed the title to follow our standards.
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Issue number: #3006
Summary
Added
+$&
as safe characters to be captured by dynamic path in API Gateway resolver.Changes
_SAFE_URI
inapi_gateway.pyL46
to include characters+
,$
and&
test_api_gateway.pyL992
to test capturing with above charactersUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
Not a breaking changeRFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.