Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): API Gateway V2 request context scope field should be optional #2961

Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2953

Summary

Changes

Include the Optional type to make the "scope" field optional.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner August 15, 2023 12:46
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2023
@github-actions github-actions bot added the bug Something isn't working label Aug 15, 2023
@heitorlessa heitorlessa changed the title fix(parser): make scope field optional fix(parser): API Gateway V2 request context scope field should be optional Aug 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (dbd80cf) 96.48% compared to head (e4726a4) 96.56%.
Report is 3 commits behind head on develop.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2961      +/-   ##
===========================================
+ Coverage    96.48%   96.56%   +0.07%     
===========================================
  Files          175      175              
  Lines         7825     7825              
  Branches      1476     1476              
===========================================
+ Hits          7550     7556       +6     
+ Misses         220      217       -3     
+ Partials        55       52       -3     
Files Changed Coverage Δ
...mbda_powertools/utilities/parser/models/apigwv2.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny test to avoid regressions

@leandrodamascena leandrodamascena linked an issue Aug 15, 2023 that may be closed by this pull request
@boring-cyborg boring-cyborg bot added the tests label Aug 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@heitorlessa heitorlessa merged commit 181fc33 into aws-powertools:develop Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: RequestContextV2AuthorizerJwt requires scopes
3 participants