Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(metrics): update Datadog integration diagram #2954

Merged
merged 3 commits into from
Aug 15, 2023
Merged

docs(metrics): update Datadog integration diagram #2954

merged 3 commits into from
Aug 15, 2023

Conversation

aal80
Copy link
Contributor

@aal80 aal80 commented Aug 14, 2023 •
edited by leandrodamascena
Loading

Issue number: #2959

Summary

Update Datadog Metrics integration diagram

Changes

Update Datadog Metrics integration diagram

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena @heitorlessa

@aal80 aal80 requested a review from a team as a code owner August 14, 2023 18:27
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 14, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 14, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2023
@aal80 aal80 changed the title Update Datadog Metrics integration diagram chore(docs): update datadog metrics integration diagram Aug 14, 2023
@heitorlessa heitorlessa changed the title chore(docs): update datadog metrics integration diagram docs(metrics): update datadog integration diagram Aug 14, 2023
@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues internal Maintenance changes labels Aug 14, 2023
@leandrodamascena
Copy link
Contributor

Hey @aal80, thanks a lot for this fix. For each PR we need an issue to track changes, but don't worry, I can create the issue and merge this PR.

I will merge this tonight.

@leandrodamascena leandrodamascena self-requested a review August 14, 2023 19:09
@leandrodamascena leandrodamascena changed the title docs(metrics): update datadog integration diagram docs(metrics): update Datadog integration diagram Aug 15, 2023
@leandrodamascena leandrodamascena removed do-not-merge need-issue PRs that are missing related issues labels Aug 15, 2023
@leandrodamascena leandrodamascena linked an issue Aug 15, 2023 that may be closed by this pull request
Docs: update Datadog integration diagram #2959
Closed
1 task
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

leandrodamascena
leandrodamascena approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leandrodamascena leandrodamascena merged commit 5bd446b into aws-powertools:develop Aug 15, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 15, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

heitorlessa pushed a commit to seshubaws/aws-lambda-powertools-python that referenced this pull request Aug 15, 2023
@aal80 @leandrodamascena @heitorlessa
docs(metrics): update Datadog integration diagram (aws-powertools#2954)
a9b6cac 
Co-authored-by: Leandro Damascena <[email protected]>
heitorlessa added a commit to seshubaws/aws-lambda-powertools-python that referenced this pull request Aug 15, 2023
@heitorlessa
Merge branch 'develop' into feat/data-masking
82bf1c3 
* develop:
  chore: cleanup, add test for single and nested
  fix(parameters): make cache aware of single vs multiple calls
  docs(roadmap): add GovCloud and China region item (aws-powertools#2960)
  docs(metrics): update Datadog integration diagram (aws-powertools#2954)
  chore(ci): changelog rebuild (aws-powertools#2958)
  chore(deps-dev): bump cfn-lint from 0.79.6 to 0.79.7 (aws-powertools#2956)
  chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (aws-powertools#2957)
  chore(deps-dev): bump xenon from 0.9.0 to 0.9.1 (aws-powertools#2955)
  feat(metrics): add Datadog observability provider (aws-powertools#2906)
  feat(event_handler): allow stripping route prefixes using regexes (aws-powertools#2521)
  chore(ci): changelog rebuild (aws-powertools#2952)
  chore(deps): bump pypa/gh-action-pypi-publish from 1.8.9 to 1.8.10 (aws-powertools#2946)
  chore(deps): bump gitpython from 3.1.31 to 3.1.32 in /docs (aws-powertools#2948)
  chore(deps-dev): bump aws-cdk from 2.90.0 to 2.91.0 (aws-powertools#2947)
  chore(ci): changelog rebuild (aws-powertools#2945)
  chore(deps-dev): bump the boto-typing group with 1 update (aws-powertools#2944)
  chore(deps): bump pypa/gh-action-pypi-publish from 1.8.8 to 1.8.9 (aws-powertools#2943)

Signed-off-by: heitorlessa <[email protected]>
seshubaws added a commit to seshubaws/aws-lambda-powertools-python that referenced this pull request Sep 8, 2023
@heitorlessa @dependabot
@leandrodamascena @github-actions @royassis @rubenfonseca @roger-zhangg @aal80 @seshubaws
chore: fix merge conflict, remove itsdangerous leftovers (#2)
5b83b66 
* fix(parameters): make cache aware of single vs multiple calls

Signed-off-by: heitorlessa <[email protected]>

* chore: cleanup, add test for single and nested

Signed-off-by: heitorlessa <[email protected]>

* chore(deps): bump pypa/gh-action-pypi-publish from 1.8.8 to 1.8.9 (aws-powertools#2943)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump the boto-typing group with 1 update (aws-powertools#2944)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Leandro Damascena <[email protected]>

* chore(ci): changelog rebuild (aws-powertools#2945)

Co-authored-by: Powertools for AWS Lambda (Python) bot <[email protected]>

* chore(deps-dev): bump aws-cdk from 2.90.0 to 2.91.0 (aws-powertools#2947)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump gitpython from 3.1.31 to 3.1.32 in /docs (aws-powertools#2948)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump pypa/gh-action-pypi-publish from 1.8.9 to 1.8.10 (aws-powertools#2946)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Leandro Damascena <[email protected]>

* chore(ci): changelog rebuild (aws-powertools#2952)

Co-authored-by: Powertools for AWS Lambda (Python) bot <[email protected]>

* feat(event_handler): allow stripping route prefixes using regexes (aws-powertools#2521)

Co-authored-by: Roy Assis <[email protected]>
Co-authored-by: Ruben Fonseca <[email protected]>

* feat(metrics): add Datadog observability provider (aws-powertools#2906)

Co-authored-by: Leandro Damascena <[email protected]>
Co-authored-by: heitorlessa <[email protected]>

* chore(deps-dev): bump xenon from 0.9.0 to 0.9.1 (aws-powertools#2955)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (aws-powertools#2957)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump cfn-lint from 0.79.6 to 0.79.7 (aws-powertools#2956)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Leandro Damascena <[email protected]>

* chore(ci): changelog rebuild (aws-powertools#2958)

Co-authored-by: Powertools for AWS Lambda (Python) bot <[email protected]>

* docs(metrics): update Datadog integration diagram (aws-powertools#2954)

Co-authored-by: Leandro Damascena <[email protected]>

* docs(roadmap): add GovCloud and China region item (aws-powertools#2960)

* fix(parameters): make cache aware of single vs multiple calls

Signed-off-by: heitorlessa <[email protected]>

* chore: cleanup, add test for single and nested

Signed-off-by: heitorlessa <[email protected]>

* chore(test): remove itsdangerous from perf test

Signed-off-by: heitorlessa <[email protected]>

* chore(deps): remove itsdangerous dependencies

* chore: disable sockets in encryption sdk tests

Signed-off-by: heitorlessa <[email protected]>

* refactor(tests): use a test double

* chore: address make pr errors

Signed-off-by: heitorlessa <[email protected]>

---------

Signed-off-by: heitorlessa <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Leandro Damascena <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Powertools for AWS Lambda (Python) bot <[email protected]>
Co-authored-by: roy <[email protected]>
Co-authored-by: Roy Assis <[email protected]>
Co-authored-by: Ruben Fonseca <[email protected]>
Co-authored-by: Roger Zhang <[email protected]>
Co-authored-by: aal80 <[email protected]>
Co-authored-by: Seshu Brahma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees

@leandrodamascena leandrodamascena

Labels
documentation Improvements or additions to documentation internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: update Datadog integration diagram
2 participants
@aal80 @leandrodamascena