Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layers): add new comercial region Israel(Tel Aviv) #2907

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2902

Summary

Changes

Expand public Lambda Layer deployment to the Israel(Tel Aviv) region.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner August 2, 2023 01:35
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code labels Aug 2, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2023
@leandrodamascena leandrodamascena linked an issue Aug 2, 2023 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the internal Maintenance changes label Aug 2, 2023
@leandrodamascena
Copy link
Contributor Author

Please do not merge before making sure we have enabled this new region in the layer account.

Need help here @sthulb.

@leandrodamascena leandrodamascena removed the request for review from sthulb August 2, 2023 10:26
@leandrodamascena
Copy link
Contributor Author

The region is now enabled. Ready to review @heitorlessa.

@heitorlessa heitorlessa changed the title chore(layers): add new comercial region Israel(Tel Aviv) feat(layers): add new comercial region Israel(Tel Aviv) Aug 3, 2023
@heitorlessa heitorlessa removed the internal Maintenance changes label Aug 3, 2023
@github-actions github-actions bot added the feature New feature or functionality label Aug 3, 2023
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this deployed already?

image

@leandrodamascena
Copy link
Contributor Author

was this deployed already?

image

It doesn't. But since we release/publish layers and bump version, the documentation will be updated to the version 41, right?!

I don't know if we need to add all versions in this new region.

@heitorlessa
Copy link
Contributor

Approving on the basis that :40 is a placeholder and we won't publish a Layer with 2.22.0 for that region alone, since it'd need a full release.

Our publish layer is locked for sealed source code created at the beginning of a release (for good measure).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@heitorlessa heitorlessa merged commit 832df6f into aws-powertools:develop Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or functionality github-actions Pull requests that update Github_actions code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add Tel Aviv region to the Lambda Layers Deployment
2 participants