-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(batch): explain record type discrepancy in failure and success handler #2868
docs(batch): explain record type discrepancy in failure and success handler #2868
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome recommendations 🚀 Loved the attention to detail in improving the code example and its name.
Requested minor changes and we can merge right afterwards.
@heitorlessa, thanks. Changes addressed. I also removed the reference to [Accessing processed messages] since every needed explanation is now in the warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last brush up after I visualized locally; I'm accepting them and merging before I head for the weekend ;)
Signed-off-by: Heitor Lessa <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Great, thanks @heitorlessa. Enjoy the weekend |
Issue number: #2816
Summary
This PR adds details to the
Batch Processor / Extending BatchProcessor
section of the docs.Changes
record
passed arg tosuccess_handler
andfailure_handler
success_handler
override caseUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? No
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.