-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(event_sources): fix DynamoDB stream event docstring #2468
docs(event_sources): fix DynamoDB stream event docstring #2468
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #2468 +/- ##
===========================================
- Coverage 97.22% 97.17% -0.05%
===========================================
Files 157 157
Lines 7306 7304 -2
Branches 523 509 -14
===========================================
- Hits 7103 7098 -5
- Misses 158 159 +1
- Partials 45 47 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing! It's so important to get the docs right, so thank you for the time preparing this!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #2462
Summary
Changes
Updating the dynamodb
deserialize
function's docstring to reflect the proper return type when deserializingN
attributes. Going fromstr
toDecimal
.Also added a missing backtick to another docstring.
User experience
It was a
str
before which was the wrong type.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.