Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): document all github action workflows and enforce least-privilege #2395

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jun 7, 2023

Issue number: #2213

Summary

Documents all GitHub Action workflows and scope permission to least privilege (remaining ones).

Changes

Please provide a summary of what's being changed

  • Document all Workflows with Process and intended Usage
  • Add Security Notice for all workflows that automate PRs (reasoning)

Unrelated change

  • Rename python_build to quality_check workflow (long-standing tech debt)

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner June 7, 2023 13:51
@heitorlessa heitorlessa requested review from leandrodamascena and removed request for a team June 7, 2023 13:51
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jun 7, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 7, 2023
@heitorlessa heitorlessa changed the title chore/ci permissions docs chore(ci): document all github action workflows and enforce least-privilege Jun 7, 2023
@github-actions github-actions bot added the internal Maintenance changes label Jun 7, 2023
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @heitorlessa!

@leandrodamascena leandrodamascena merged commit b99f65b into aws-powertools:develop Jun 7, 2023
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Jun 7, 2023
* develop:
  chore(ci): fix PR labeling permission scope (aws-powertools#2396)
  chore(ci): document all github action workflows and enforce least-privilege (aws-powertools#2395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants