fix(build): auto-generate setup.py for legacy build tools #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Thulbourn <[email protected]>
boring-cyborg
bot
added
the
dependencies
pull-request-size
bot
added
the
size/XS
heitorlessa
changed the title
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
github-actions
bot
added
do-not-merge
need-issue
heitorlessa
approved these changes
Mar 15, 2023
|
@awslabs/aws-lambda-powertools-python No related issues found. Please ensure 'pending-release' label is applied before releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2012
Summary
Changes
pyproject.toml has a new section to re-enable the generation of setup.py
User experience
As a result of a change in (poetry-core), this project no longer generates a setup.py file when building, this could be required by other users of the package for things like third party vending of packages.
This PR restores the generation of setup.py
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.