-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parameters): migrate AppConfig to new APIs due to API deprecation #1553
feat(parameters): migrate AppConfig to new APIs due to API deprecation #1553
Conversation
Codecov ReportBase: 99.42% // Head: 99.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #1553 +/- ##
==========================================
- Coverage 99.42% 99.38% -0.04%
==========================================
Files 125 125
Lines 5726 5731 +5
Branches 357 359 +2
==========================================
+ Hits 5693 5696 +3
Misses 18 18
- Partials 15 17 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Giving feedback here. |
Looking into this now [apologies for the delay, re:Invent deadlines are tighter this year] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @leandrodamascena for working on this, truly!
I've made some wording suggestions, and some concerns on E2E tests:
- Separate SSM from this PR for a clean cut and revert if we need
- Some resources have names hardcoded, this might bite us back in parallel testing or network failures (e.g., SSM will fail subsequent stack if a param name already exists)
Heiiiiii @heitorlessa! I've addressed all the feedback and I think we're ready to merge. Thank you so much for reviewing this, every time you give me WONDERFUL feedback to think about UX and see beyond the code. ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU! I'm glad we're completing this and we're ready for the grooming part before launching V2 now.
Last suggestions I'm committing myself is on being more explicit on AppConfig Config/Env Name and Description. If a network split happens, this will leave dangling resources making it difficult to trace back to what they are for (appe2e
vs powertools-e2e-x
).
#1553) Co-authored-by: Heitor Lessa <[email protected]>
Issue number: #1506
Summary
Changes
Due to Deprecation of the AppConfig API, we needed to change the SDK client to call the new APIs.
We had a long discussion in this issue #1506 before applying these changes.
User experience
No changes are required to Lambda functions that use
Feature Flags and AppConfig Parameter utility
, but users must addappconfig:GetLatestConfiguration
andappconfig:StartConfigurationSession
IAM permissions for this to work in their Lambdas.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/upgrade.md