-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idempotency): support methods with the same name (ABCs) by including fully qualified name in v2 #1535
feat(idempotency): support methods with the same name (ABCs) by including fully qualified name in v2 #1535
Conversation
Codecov ReportBase: 99.42% // Head: 99.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #1535 +/- ##
==========================================
- Coverage 99.42% 99.42% -0.01%
==========================================
Files 128 125 -3
Lines 5745 5726 -19
Branches 670 671 +1
==========================================
- Hits 5712 5693 -19
Misses 18 18
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the Lambda function is lacking permissions to RW to DDB.
Great job! I left some comments, but I would like to share some ideas about improving the e2e tests
Actually I was missing the RW Permissions for DDB, but I'll investigate why I'm running fine here even without this permission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is SOOOOOOOOOO awesome Leandro, fantastic job! Just left a slight note for us to think about, but maybe it's not a problem.
Should we also update the docs/upgrade.md
explaining the breaking change?
Heyyyy @rubenfonseca, thank you so much for this feedback, I appreciate a lot! I like the way you encourage the work of others! ✌️ 🚀 I agree 100% that we must update the documentation and I did. Please review this and add what you think is important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ding fully qualified name in v2 (#1535) Co-authored-by: Rúben Fonseca <[email protected]>
Issue number: #1330
Summary
Changes
This change modifies the name of the key generated by the idempotency methods. In case you have 2 functions with the same name, the hash is calculated only for the first one and the other one cannot use the idempotency function.
User experience
Before to this change, the idempotency key was just using the function name:
After this change, the idempotency key includes the module and Python qualified name (PEP 3155)
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/utilities/idempotency.md