-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): create reusable docs publishing workflow #1482
Merged
heitorlessa
merged 7 commits into
aws-powertools:develop
from
heitorlessa:chore/reusable-docs-workflow
Aug 29, 2022
Merged
chore(ci): create reusable docs publishing workflow #1482
heitorlessa
merged 7 commits into
aws-powertools:develop
from
heitorlessa:chore/reusable-docs-workflow
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
heitorlessa
requested review from
leandrodamascena
and removed request for
a team
August 29, 2022 14:02
boring-cyborg
bot
added
the
github-actions
Pull requests that update Github_actions code
label
Aug 29, 2022
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Aug 29, 2022
heitorlessa
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Aug 29, 2022
rubenfonseca
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, great job.
heitorlessa
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Aug 29, 2022
heitorlessa
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Aug 29, 2022
pull-request-size
bot
removed
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Aug 29, 2022
rubenfonseca
pushed a commit
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github-actions
Pull requests that update Github_actions code
internal
Maintenance changes
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1333
Summary
Changes
This PR breaks the multiple ways to build and publish user guide & API docs to prevent future mistakes. It migrates all manual docs steps to use the new
reusable_publish_docs.yml
workflow. This will make it easier to support v1 and v2 docs too.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.