-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): enable end-to-end test workflow #1470
Merged
heitorlessa
merged 9 commits into
aws-powertools:develop
from
heitorlessa:chore/enable-e2e
Aug 23, 2022
Merged
chore(tests): enable end-to-end test workflow #1470
heitorlessa
merged 9 commits into
aws-powertools:develop
from
heitorlessa:chore/enable-e2e
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heitorlessa
requested review from
leandrodamascena
and removed request for
a team
August 23, 2022 13:00
boring-cyborg
bot
added
dependencies
Pull requests that update a dependency file
github-actions
Pull requests that update Github_actions code
internal
Maintenance changes
labels
Aug 23, 2022
pull-request-size
bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Aug 23, 2022
rubenfonseca
approved these changes
Aug 23, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1470 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 123 123
Lines 5497 5498 +1
Branches 629 629
========================================
+ Hits 5491 5492 +1
Misses 2 2
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It was a trap! I thought it was ready for review! |
HAHAHAHA almost there! |
Ready to go @rubenfonseca ! |
rubenfonseca
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
github-actions
Pull requests that update Github_actions code
internal
Maintenance changes
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1435
Summary
This PR enables our new E2E framework to run on push and manually.
It also (1) refreshes the contributing guide to include our testing definition, and (2) maintainers playbook to include more info on the E2E test structure.
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered CONTRIBUTING.md