Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(parser): minor grammar fix #1427

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

peterschutt
Copy link
Contributor

@peterschutt peterschutt commented Aug 6, 2022

Issue number: #1428

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/utilities/parser.md

@peterschutt peterschutt requested a review from a team as a code owner August 6, 2022 08:40
@peterschutt peterschutt requested review from heitorlessa and removed request for a team August 6, 2022 08:40
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Aug 6, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2022

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues labels Aug 6, 2022
@heitorlessa heitorlessa changed the title Minor grammar fix docs(parser): minor grammar fix Aug 9, 2022
@heitorlessa heitorlessa removed do-not-merge need-issue PRs that are missing related issues labels Aug 9, 2022
@heitorlessa
Copy link
Contributor

Thanks again @peterschutt ! We're going to recreate all examples and revisit the entire Parser wording next - if you find anything else please drop a note here: #1371

@leandrodamascena started working on that

@heitorlessa heitorlessa merged commit 6b23903 into aws-powertools:develop Aug 9, 2022
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Aug 10, 2022
* develop:
  chore(ci): update changelog with latest changes
  docs(parser): minor grammar fix (aws-powertools#1427)
  chore(ci): update changelog with latest changes
  docs(apigateway): removes duplicate admonition (aws-powertools#1426)
  chore(ci): update changelog with latest changes
  docs(jmespath_util): snippets split, improved, and lint (aws-powertools#1419)
  chore(ci): reduce payload and only send prod notification
heitorlessa pushed a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants