-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(event_handlers): ImportError when importing Response from top-level event_handler #1388
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov Report
@@ Coverage Diff @@
## develop #1388 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5429 5429
Branches 620 620
========================================
Hits 5423 5423
Misses 2 2
Partials 4 4
Continue to review full report at Codecov.
|
Thank you @VictorCovalski for spotting this, our automated linting for documentation somehow missed that. I'm creating a quick bug report to associate this fix with, and should merge soon. Unless you deem it to be critical to warrant a patch release today, you should be able to import from aws_lambda_powertools.event_handler.api_gateway import Response We should make a release on Friday by EOD with this fix either way. |
Thanks for the quick reply @heitorlessa. I'll follow your suggestion until the next release. |
Merging. It's great to hear from another fellow Brazilian (muito obrigado!!). |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(event_handlers): ImportError when importing Response from top-level event_handler (#1388)
Thanks to your @VictorCovalski PR, we've identified that static analysis (mypy) weren't including |
Issue number: #1389
Summary
The docs mention a
Response
that allows one to customize a Response that gets returned to API Gatewayhttps://awslabs.github.io/aws-lambda-powertools-python/latest/core/event_handler/api_gateway/#fine-grained-responses
However, in the current version the Response object is not included in the
__init__.py
file located in theevent_handler
sub package. This PR fixes that.Changes
Very minor.
User experience
None. It will match what the documentation mentions.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.