Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info how to get layer versions from the SAR for the layers #134

Closed
wants to merge 3 commits into from
Closed

docs: add info how to get layer versions from the SAR for the layers #134

wants to merge 3 commits into from

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Aug 26, 2020

Issue #, if available:

Description of changes:

The AWS console does not show the available versions of the SAR app for the layers we have recently published. I added the CLI command this the ARN to fetch the available versions.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #134 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          706       706           
  Branches        66        67    +1     
=========================================
  Hits           706       706           
Impacted Files Coverage Δ
aws_lambda_powertools/logging/formatter.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814062e...d16c7bf. Read the comment docs.

@heitorlessa
Copy link
Contributor

Great addition. While you're at it, could you add some quick notes on what to do after deployed?

Where can they find the Layer Arn to use? Outputs?

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add instruction on how to find the Layern ARN after deploying the SAR App

@am29d
Copy link
Contributor Author

am29d commented Aug 26, 2020

Unfortunately, you have first to deploy the SAR app to get the LayerVersionArn as an exported value that can be referenced in a Lambda function resource definition. You can not do this within one SAM template and deploy the app and the lambda in one go :(.

I added two options in the documentation, either way you need to deploy two times.

@am29d
Copy link
Contributor Author

am29d commented Aug 28, 2020

close this pr and reopened in #145 , because I screw up my fork repo and had to create new.

@am29d am29d closed this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants