Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): adds caching when installing python dependencies #1311

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Jul 18, 2022

Issue number: #1009

Summary

This PR fixes a bug when running the publish document action, where dependencies were not installed. This caused the build to fail.

I also added poetry dependency caching on all the relevant workflows. This should improve our github actions build time.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Jul 18, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2022
@github-actions github-actions bot added the internal Maintenance changes label Jul 18, 2022
@rubenfonseca rubenfonseca marked this pull request as ready for review July 18, 2022 12:16
@rubenfonseca rubenfonseca requested a review from heitorlessa July 18, 2022 12:17
@heitorlessa
Copy link
Contributor

Thank you @rubenfonseca !!!

@heitorlessa heitorlessa merged commit df058ba into aws-powertools:develop Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants