Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(parser): extract and fix code examples #1125

Closed
wants to merge 16 commits into from

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Apr 13, 2022

Issue number:

Summary

Extract code examples from the parser utility documentation and fix python code examples

Changes

Please provide a summary of what's being changed

Changes:

  • Extract code examples
  • Run isort and black
  • Fix python code examples with errors
  • Update line highlights
  • Add make task for formatting, compiling and linting examples to prevent future errors

Bug Fixes included in this PR:

User experience

Please share what the user experience looks like before and after this change

Before some examples would have errors in them, afterwords these errors where fix, also some make tasks where added to reduce future errors.

Hosted version is here: https://gyft.github.io/aws-lambda-powertools-python/latest/

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/utilities/parser.md

Changes:
- Extract code examples
- Run isort and black
- Fix python code examples
- Update line highlights
- Add make task

Related to:
- aws-powertools#1064
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 13, 2022
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal Maintenance changes labels Apr 13, 2022
@michaelbrewer
Copy link
Contributor Author

@ran-isenberg - FYI, i have extracted the code examples for the parser utility in this PR instead of the main docs PR

@github-actions github-actions bot added the bug Something isn't working label Apr 13, 2022
@michaelbrewer michaelbrewer changed the title fix(docs): Extract parser code examples fix(docs): Extract parser code examples Apr 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #1125 (b49e336) into develop (f62d07a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1125   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files          119      119           
  Lines         5423     5423           
  Branches       618      618           
========================================
  Hits          5417     5417           
  Misses           2        2           
  Partials         4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62d07a...b49e336. Read the comment docs.

@michaelbrewer michaelbrewer changed the title fix(docs): Extract parser code examples fix(docs): Extract and fix parser code examples Apr 20, 2022
@heitorlessa heitorlessa removed the bug Something isn't working label Apr 26, 2022
@heitorlessa heitorlessa changed the title fix(docs): Extract and fix parser code examples docs(parser): extract and fix code examples Apr 26, 2022
@sthulb sthulb closed this Jun 14, 2022
@gshpychka
Copy link

@sthulb any insights into why these were all closed?

@heitorlessa
Copy link
Contributor

Hi @gshpychka, Michael is no longer part of the Lambda Powertools community.

For any specific concerns, please feel free to email us at [email protected].

@gshpychka
Copy link

Hi @gshpychka, Michael is no longer part of the Lambda Powertools community.

For any specific concerns, please feel free to email us at [email protected].

I'm not sure what that means, but why did all his PRs have to be closed?

@ran-isenberg
Copy link
Contributor

The parser and feature flags could have really benefited from the docs overhaul PRs

@heitorlessa
Copy link
Contributor

heitorlessa commented Jun 23, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants