-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(parser): extract and fix code examples #1125
Conversation
Changes: - Extract code examples - Run isort and black - Fix python code examples - Update line highlights - Add make task Related to: - aws-powertools#1064
@ran-isenberg - FYI, i have extracted the code examples for the parser utility in this PR instead of the main docs PR |
parser
code examples
Codecov Report
@@ Coverage Diff @@
## develop #1125 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5423 5423
Branches 618 618
========================================
Hits 5417 5417
Misses 2 2
Partials 4 4 Continue to review full report at Codecov.
|
parser
code examplesparser
code examples
parser
code examples
@sthulb any insights into why these were all closed? |
Hi @gshpychka, Michael is no longer part of the Lambda Powertools community. For any specific concerns, please feel free to email us at [email protected]. |
I'm not sure what that means, but why did all his PRs have to be closed? |
The parser and feature flags could have really benefited from the docs overhaul PRs |
We will tackle all of them, Ran. We’ll also introduce a built-in API
reference docs so Parser Models (et al) can be automatically documented
…On Thu, 23 Jun 2022 at 08:55, Ran Isenberg ***@***.***> wrote:
The parser and feature flags could have really benefited from the docs
overhaul PRs
—
Reply to this email directly, view it on GitHub
<#1125 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBDYLCHGJ53L6EWZKNTVQQC5TANCNFSM5TJFEEPQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Issue number:
Summary
Extract code examples from the parser utility documentation and fix python code examples
Changes
Changes:
isort
andblack
make
task for formatting, compiling and linting examples to prevent future errorsBug Fixes included in this PR:
EventBridge Envelope
exampleUser experience
Before some examples would have errors in them, afterwords these errors where fix, also some
make
tasks where added to reduce future errors.Hosted version is here: https://gyft.github.io/aws-lambda-powertools-python/latest/
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/utilities/parser.md