-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(parameters): extract and fix code examples #1124
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Extract code examples - Run isort and black - Fix python examples - Update line highlights - Add make task Related to: - aws-powertools#1064
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Apr 13, 2022
boring-cyborg
bot
added
documentation
Improvements or additions to documentation
internal
Maintenance changes
labels
Apr 13, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1124 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 119 119
Lines 5423 5423
Branches 618 618
========================================
Hits 5417 5417
Misses 2 2
Partials 4 4 Continue to review full report at Codecov.
|
michaelbrewer
changed the title
fix(docs): Extract
fix(docs): Extract and fix Apr 20, 2022
parameters
code examplesparameters
code examples
heitorlessa
changed the title
fix(docs): Extract and fix
docs(parameters): extract and fix code examples
Apr 26, 2022
parameters
code examples
Updated to include the latest parameter changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
internal
Maintenance changes
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Summary
Changes
Changes:
isort
andblack
make
task to format, compile and lint examples to prevent errors happening again.Bug fixes included in this PR:
Creating a S3 Provider to fetch parameters
exampleUser experience
Code examples now include the correct imports
Hosted version is here: https://gyft.github.io/aws-lambda-powertools-python/latest/
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/utilities/parameters.md